Closed
Bug 745703
Opened 12 years ago
Closed 12 years ago
XBL for menu-button inherits accessKey instead of accesskey
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: danielcdawson, Assigned: atte)
Details
Attachments
(1 file)
|
1.12 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
The content button in the XBL at chrome://global/content/bindings/button.xml#menu-button has "accessKey" (uppercase "K") in its inherits list. But this should be "accesskey" (lowercase). This usually results in the accesskey not being underlined, although the key still activates the button. Also, if the accesskey comes from a command element, it becomes underlined on mouseover.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #636409 -
Flags: review?(enndeakin)
|
||
Updated•12 years ago
|
Attachment #636409 -
Flags: review?(enndeakin) → review+
|
|
||
Comment 2•12 years ago
|
||
Thanks for the patch. Do you need help to check it in?
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 3•12 years ago
|
||
Yeah, I have no idea how checking is done.
|
|
||
Comment 4•12 years ago
|
||
If you set the 'checkin-needed' keyword on the bug, as I've done, someone may come along and check it in. If not, you can ask on the #developers irc channel for someone to.
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/2ee8a6148b94 Nice job on your first patch Atte. If everything goes smoothly, your patch will be merged to mozilla-central within a day or two.
|
|
||
Updated•12 years ago
|
Target Milestone: --- → mozilla16
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ee8a6148b94
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•