Closed
Bug 745755
Opened 12 years ago
Closed 10 years ago
Generate a marketplace bookmark on profile creation?
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(blocking-kilimanjaro:-, firefox29 verified, blocking-fennec1.0 -)
People
(Reporter: aaronmt, Assigned: Margaret)
Details
Attachments
(1 file)
9.43 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/mobile/locales/generic/profile/bookmarks.json.in Would it make sense to generate a marketplace bookmark on new profile creation considering there is one for AMO? -- title: Mozilla Marketplace icon: http://mxr.mozilla.org/mozilla-central/source/mobile/locales/generic/profile/bookmarks.json.in#10 URI: http://marketplace.mozilla.org --
Reporter | ||
Updated•12 years ago
|
Component: Web Apps → General
QA Contact: web-apps → general
Reporter | ||
Comment 1•12 years ago
|
||
Soft-release blocker for Mozilla Marketplace discoverability?
blocking-fennec1.0: --- → ?
Updated•12 years ago
|
blocking-fennec1.0: ? → -
Updated•12 years ago
|
blocking-kilimanjaro: --- → ?
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8366833 -
Flags: review?(wjohnston)
Comment 5•10 years ago
|
||
Comment on attachment 8366833 [details] [diff] [review] add marketplace bookmark Review of attachment 8366833 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/strings.xml.in @@ +309,5 @@ > <string name="bookmarkdefaults_url_support">http://support.mozilla.org/@AB_CD@/products/mobile</string> > <string name="bookmarkdefaults_favicon_abouthome">chrome/chrome/content/branding/favicon64.png</string> > > + <string name="bookmarkdefaults_title_marketplace">@bookmarks_marketplace@</string> > + <string name="bookmarkdefaults_url_marketplace">https://marketplace.firefox.com/</string> It might be nice to add a comment that the favicon will automatically come from the marketplace.png drawable.
Attachment #8366833 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 6•10 years ago
|
||
This was green on try: https://tbpl.mozilla.org/?tree=Try&rev=fa62d24db724 Added some more comments to explain the "magic": https://hg.mozilla.org/integration/fx-team/rev/dc13e23057af
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dc13e23057af
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Reporter | ||
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
status-firefox29:
--- → verified
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•