745765 - Reuse existing tab for same app launch in about:apps

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Aaron Train [:aaronmt]]

Currently when one launches the same application (as is currently running in a separate tab) in about:apps, a new tab is created.

STR:

i) https://apps.mozillalabs.com/appdir/ -- install any app
ii) about:apps, launch app (new tab is created)

Repeat ii., a new tab is created.

Shouldn't it reuse the existing tab?

--
Nightly (04/16)
Samsung Galaxy Nexus (Android 4.0.4)

Comment 1

[Jason Smith [:jsmith]]

I believe this was working when the first about:apps patch landed (reuse of the existing tab). Flagging as a regression.

Comment 2

[Jason Smith [:jsmith]]

Implementation of this bug needs to be consistent with bug 745745.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

The problem was the WebappsUI.openURL code was using aOrigin as the "cookie" but the homescreen intent was using the launch URI. This patch makes the WebappsUI.openURL code use the excact same code as the homescreen intent. Both paths use the launch URI as the "cookie" to tag a tab.

Comment 5

[Jason Smith [:jsmith]]

Note for testing - Make sure this is tested by launching the same application twice both from about:apps and from a homescreen shortcut.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

soft blocking nom. fixes launch behavior for webapps.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b890b87bac9

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7b890b87bac9

Comment 9

[Aaron Train [:aaronmt]]

Verified Fixed

Nightly (04/29)
Samsung Galaxy Note (Android 2.3), Samsung Galaxy Nexus (Android 4.0.4)

Comment 10

[Aaron Train [:aaronmt]]

MozTrap: https://moztrap.mozilla.org/manage/case/258/