Closed
Bug 745879
Opened 12 years ago
Closed 12 years ago
OAuth dialog url and secure icon not vertically aligned properly
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: mconley, Assigned: Paenglab)
References
Details
Attachments
(5 files, 5 obsolete files)
6.24 KB,
image/png
|
Details | |
4.32 KB,
image/png
|
Details | |
14.07 KB,
image/png
|
Details | |
7.98 KB,
image/png
|
Details | |
2.74 KB,
patch
|
Paenglab
:
review+
Bienvenu
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
On Windows 7, XP and on OSX, the little green circle icon and the URL seem to be misaligned. See screenshots.
Reporter | ||
Updated•12 years ago
|
OS: Windows 7 → All
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
The description (the URL) has a margin-bottom of 4px but on top only 1px. This patch gives on top a margin of 3px. This centers the text better and also the secure icon. When I give on bottom a margin of 3px the icon is no more centered. On Mac I changed the useless padding-right: 5px to a working margin-right: 5px to give a gap between icon and text.
Attachment #615447 -
Flags: review?(mconley)
Assignee | ||
Comment 4•12 years ago
|
||
Oops a tab instead of spaces slipped in.
Attachment #615448 -
Flags: review?(mconley)
Assignee | ||
Updated•12 years ago
|
Attachment #615447 -
Attachment is obsolete: true
Attachment #615447 -
Flags: review?(mconley)
Reporter | ||
Comment 5•12 years ago
|
||
Hey Paenglab, Thanks for tackling this! I've noticed that the icon is still not exactly centered vertically on Ubuntu. See screenshot. Care to tweak it? -Mike
Assignee | ||
Comment 6•12 years ago
|
||
This should be better.
Assignee: nobody → richard.marti
Attachment #615448 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #615448 -
Flags: review?(mconley)
Attachment #615750 -
Flags: review?(mconley)
Reporter | ||
Comment 7•12 years ago
|
||
Paenglab, So OSX, Ubuntu, and Windows XP / Classic all look great now. Windows Aero still looks a bit off. See screenshot. -Mike
Attachment #615718 -
Attachment is obsolete: true
Assignee | ||
Comment 8•12 years ago
|
||
Added browserRequest-aero.css to fix the differences between XP and Win7.
Attachment #615750 -
Attachment is obsolete: true
Attachment #615750 -
Flags: review?(mconley)
Attachment #615810 -
Flags: review?(mconley)
Reporter | ||
Comment 9•12 years ago
|
||
Comment on attachment 615810 [details] [diff] [review] Fix v3 Review of attachment 615810 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Paenglab - looks great! Just one nit. Once fixed, r=me. ::: mail/themes/pinstripe/mail/browserRequest.css @@ +75,5 @@ > font-weight: normal; > } > + > +#headerMessage { > + margin-top: 3px; These should be indented 2 spaces, not 4.
Attachment #615810 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Patch addressing review Carrying over r+
Attachment #615810 -
Attachment is obsolete: true
Attachment #615861 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 11•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/db79074493e3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Reporter | ||
Comment 12•12 years ago
|
||
Comment on attachment 615861 [details] [diff] [review] Patch for check-in addressing comment We want this for Filelink.
Attachment #615861 -
Flags: approval-comm-aurora?
Updated•12 years ago
|
Attachment #615861 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Reporter | ||
Comment 13•12 years ago
|
||
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/a1a9b3984c5a
status-thunderbird13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•