746148 - When unable to find dictionary try also LANG variable to determine dictionary

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Jan Horak [:jhorak]]

Attachment: patch 0.1

Mozilla tries to determine spell check dictionary by using locale. This doesn't work for Linux distributions which wants to share dictionaries across the system. In this case it picks the first available dictionary as default. 

Attaching patch which tries to set dictionary from LANG environment variable just before 'en-US' will be tried. Please have a look.

Comment 1

[(no longer active)]

Comment on attachment 615716 [details] [diff] [review]
patch 0.1

Review of attachment 615716 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/composer/src/nsEditorSpellCheck.cpp
@@ +752,5 @@
> +      if (env_lang != nsnull) {
> +        nsString lang = NS_ConvertUTF8toUTF16(env_lang);
> +        // strip charset if there is any
> +        PRInt32 pos;
> +        if ( (pos = lang.FindChar('.')) != -1) {

Nit: please call FindChar on the previous line, and just compare in the condition.

@@ +761,2 @@
>        if (NS_FAILED(rv)) {
> +        rv = SetCurrentDictionary(NS_LITERAL_STRING("en-US"));

Why do you need to assume en-US first here?

Comment 2

[Jan Horak [:jhorak]]

Attachment: patch 0.2

I'm little confused here, the en-US used to be here before, I've just added LANG check before trying en-US. Or do you mean the en-US should have higher priority?

Comment 3

[(no longer active)]

Comment on attachment 616078 [details] [diff] [review]
patch 0.2

Review of attachment 616078 [details] [diff] [review]:
-----------------------------------------------------------------

No, sorry, I just read the patch incorrectly.  r=me.

Note for the drivers: this does not impact Fennec as spellchecking is currently disabled there.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6294c13ee51e

Thanks for your patch!

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/6294c13ee51e