746164 - Failure for the shortcut keys in actions/test_keys.html b/accessible/tests/mochitest/actions/test_keys.html

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P3)

Description

[Marco Zehe (:MarcoZ)]

Log file says:
255 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/actions/test_keys.html | Wrong keyboard shortcut on  'input2'  - got %b, expected b
256 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/actions/test_keys.html | Wrong keyboard shortcut on  'link'  - got %l, expected l

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Fix

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 615727 [details] [diff] [review]
Fix

Review of attachment 615727 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/actions/test_keys.html
@@ +26,5 @@
>      function doTest()
>      {
>        testKeyboardShortcut("input1", "");
> +      testKeyboardShortcut("input2", MAC ? "⌃%b" : "Alt+Shift+b");
> +      testKeyboardShortcut("link", MAC ? "⌃%l" : "Alt+Shift+l");

interesting, there's no '^' in report: "got %b, expected b"

Comment 3

[Marco Zehe (:MarcoZ)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/cefa04404a30

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cefa04404a30

Comment 5

[Marco Zehe (:MarcoZ)]

Attachment: Proper character for Option key, the one in the previous patch was wrong.

Comment 6

[Hubert Figuiere [:hub]]

reopening

Comment 7

[Hubert Figuiere [:hub]]

Comment on attachment 618290 [details] [diff] [review]
Proper character for Option key, the one in the previous patch was wrong.

Review of attachment 618290 [details] [diff] [review]:
-----------------------------------------------------------------

tested. works.

Comment 8

[Marco Zehe (:MarcoZ)]

Proper fix on inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/5b623170c1d4

Comment 9

[Ed Morley [:emorley]]

(In reply to Marco Zehe (:MarcoZ) from comment #8)
> Proper fix on inbound:
> http://hg.mozilla.org/integration/mozilla-inbound/rev/5b623170c1d4

Sorry, push backed out for linux mochitest-other orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&onlyunstarred=1&rev=8cc13f37bc66
https://tbpl.mozilla.org/php/getParsedLog.php?id=11222399&tree=Mozilla-Inbound

{
4512 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/events/test_focus_listcontrols.xul | Error in test: proposed current item 'ml_tangerine' is already current
}

https://hg.mozilla.org/integration/mozilla-inbound/rev/922510fc28aa

Comment 10

[Marco Zehe (:MarcoZ)]

Relanded with bustage fix: http://hg.mozilla.org/integration/mozilla-inbound/rev/175a8c81e3ff

Comment 11

[Morgan Reschenberg [:morgan]]

Closing, as this test is running in tree and there are no recent or intermittent failures.