746223 - remove -l flag from nsinstall

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

As bug 745209 showed, nsinstall's -l flag is busted and unused (-L implies it; -R is more convenient to use).  We should just remove it so it doesn't cause problems elsewhere.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 661923 [details] [diff] [review]
patch

Review of attachment 661923 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/nsinstall.c
@@ +289,5 @@
>  	    linkprefix = optarg;
>  	    lplen = strlen(linkprefix);
>  	    dolink = 1;
>  	    break;
>       case 'R':

While you're here, can you indent this properly?

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #2)
> @@ +289,5 @@
> >  	    linkprefix = optarg;
> >  	    lplen = strlen(linkprefix);
> >  	    dolink = 1;
> >  	    break;
> >       case 'R':
> 
> While you're here, can you indent this properly?

"Properly" is such an ambiguous description when applied to nsinstall.c's formatting. ;)

https://hg.mozilla.org/integration/mozilla-inbound/rev/be916ac9a1b4

Comment 4

[(no longer active)]

Broke the build across the board, so I backed it out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7fce994eaa

Comment 5

[Gregory Szorc [:gps]]

(In reply to Mike Hommey [:glandium] from comment #2)
> While you're here, can you indent this properly?

But... but... this file adds character to the tree with its mixed usage of spaces and tabs ON THE SAME LINE! :)

Comment 6

[Nathan Froyd [:froydnj]]

Relanded with changes to js/src/config as well:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed057f2acc29

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/ed057f2acc29