Closed
Bug 746228
Opened 12 years ago
Closed 12 years ago
pack JSPropertyDescriptor better on 64-bit hosts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
1.06 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
JSProperty descriptor is currently laid out like so: JSObject *obj; unsigned attrs; JSPropertyOp getter; JSStrictPropertyOp setter; jsval value; unsigned shortid; which on 64-bit platforms introduces eight bytes of padding: four after each unsigned member. The fields should be reordered to eliminate said padding. Patch coming up.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #615782 -
Flags: review?(luke)
Comment 2•12 years ago
|
||
Comment on attachment 615782 [details] [diff] [review] patch Could you fix the alignment of attrs and shortid? These are some style casualties from the recent removal of uintN.
Attachment #615782 -
Flags: review?(luke) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/projects/birch/rev/636b1b09842e
Assignee: general → nfroyd
Status: NEW → ASSIGNED
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/636b1b09842e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•