746369 - Cannot install apps that do not specify an icon in the app manifest - Clicking Install in App Doorhanger Does Nothing

Status: VERIFIED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Jason Smith [:jsmith]]

Steps:

1. Install Nightly try-build (http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7c9ffc51663f/)
2. Go to marketplace-dev.allizom.org
3. Install the In-App Payment tester (https://marketplace-dev.allizom.org/en-US/app/in-app-payment-tester/?src=search)
4. When the door-hanger appears, click install

Expected:

The application should install natively to the user's machine.

Actual:

Nothing happens. The door hanger is still persistent. Continuing to click install does nothing.

Error Console:

Error: TypeError: aIcons is not an object
Source File: resource:///modules/WebappsInstaller.jsm
Line: 366

Comment 1

[:Felipe Gomes (needinfo for replies!)]

This app's manifest does not specify icons: http://inapp-pay-test.farmdev.com/en-US/manifest.webapp

{"name": "In-app Payment Tester",
 "description": "Utility app to test in-app payments.",
 "version": "1.0",
 "developer": {"name": "---"},
 "launch_path": "/en-US/",
 "default_locale": "en",
 "installs_allowed_from": ["*"]
}

Should the marketplace accept apps without icons?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Felipe Gomes (:felipe) from comment #1)
> This app's manifest does not specify icons:
> http://inapp-pay-test.farmdev.com/en-US/manifest.webapp
> 
> {"name": "In-app Payment Tester",
>  "description": "Utility app to test in-app payments.",
>  "version": "1.0",
>  "developer": {"name": "---"},
>  "launch_path": "/en-US/",
>  "default_locale": "en",
>  "installs_allowed_from": ["*"]
> }
> 
> Should the marketplace accept apps without icons?

I don't know (I'll check with Krupa), although the issue here could happen outside of the marketplace. Specifying icons is optional (https://developer.mozilla.org/en/Apps/Manifest). The case of when an icon isn't specified does need to be handled.

Comment 3

[Jennifer Arguello :ticachica]

Need Krupa's and/or Marketplace team's take on this. 

If it's not necessary in the Mozilla Marketplace, I would not block on this release if the case is that 3rd party marketplaces cannot install without an icon since there are no 3rd party marketplaces at this time.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Jennifer Arguello :ticachica from comment #3)
> Need Krupa's and/or Marketplace team's take on this. 

Krupa and Wil - Thoughts?

> If it's not necessary in the Mozilla Marketplace, I would not block on this
> release if the case is that 3rd party marketplaces cannot install without an
> icon since there are no 3rd party marketplaces at this time.

Remember that users can host their own applications freely, which we already know is being used. How does 3rd party app hosting get taken into account in this?

Comment 5

[krupa raj[:krupa]]

app icons are not required to submit an app in Marketplace.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

What is then the icon that should be used if an app does not submit its own icon?

Comment 7

[Justin Scott [:fligtar]]

(In reply to Felipe Gomes (:felipe) from comment #6)
> What is then the icon that should be used if an app does not submit its own
> icon?

Can we use the rocket glyph as the default icon? We're seeing this bug quite a bit in trying to install Marketplace apps. Depending on ETA for a fix, we may need to reject apps without icons in their manifest for now.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

If an app does not specify icons in the manifest this will use the rocket icon, thesame as displayed in the doorhanger

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v2

forgot to qref

Comment 10

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/mozilla-central/rev/22bfdebf5cae