Closed Bug 746588 Opened 12 years ago Closed 12 years ago

[Azure] Cairo-pattern matrices specify the conversion from DrawTarget to pattern but Azure is inverted

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: gw280, Assigned: gw280)

References

Details

Attachments

(1 file)

Matrices in Azure specify the conversion from pattern to DT space; we do not handle this in gfxPattern.cpp in SetMatrix()
Patch from Bas
Attachment #616152 - Flags: review?(jmuizelaar)
Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

Review of attachment 616152 [details] [diff] [review]:
-----------------------------------------------------------------

Does this affect D2D?
Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

Review of attachment 616152 [details] [diff] [review]:
-----------------------------------------------------------------

Does this affect D2D?
Attachment #616152 - Flags: review?(jmuizelaar) → review+
Attachment #616152 - Flags: approval-mozilla-central?
Blocks: 740580
Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

Review of attachment 616152 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPattern.cpp
@@ +134,5 @@
>      mTransform = ToMatrix(matrix);
> +    // Cairo-pattern matrices specify the conversion from DrawTarget to pattern
> +    // space. Azure pattern matrices specify the conversion from pattern to
> +    // DrawTarget space.
> +    mTransform.Invert();

should this be azure only then?
Yes, this only affects azure for content drawing with basic layers.
Comment on attachment 616152 [details] [diff] [review]
invert the matrix in SetMatrix

[Triage Comment]
Desktop only, approved for central.
Attachment #616152 - Flags: approval-mozilla-central? → approval-mozilla-central+
https://hg.mozilla.org/mozilla-central/rev/d400d7f9eadd
Assignee: nobody → gwright
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: