746633 - Flash flickers at the end of a pan or zoom on gingerbread and froyo

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

Visit a site thats build on full flash, and watch yourself panning and tapping the screen will flicker.   Visit the URL in the bug for an example.  

Here's a video: http://www.youtube.com/watch?v=jrxePPRFyAg

Repro:
1) 04-17-2012 nightly, HTC Sensation, Android 2.3.4
2) visit a full flash site.  (see URL.  also gotmilk.com is one)
3) when site finishes loading, try to pan the screen.   
4) Verify page flickers.

Expected:
- No flash site flickering

Actual:
- flickering

Comment 1

[Martijn Wargers (dead)]

Related to bug 727116?
Bug 719865 was marked as a duplicate of that bug.

Comment 2

[Tony Chung [:tchung]]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #1)
> Related to bug 727116?
> Bug 719865 was marked as a duplicate of that bug.

Yeah possibly.  i can't reproduce the flash flickering on my Galaxy Nexus, Android 4.0.2.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

snorp will be landing a major change to how we paint flash, so please retest once that lands.

Snorp, can you put the bug number for that in a comment here?

Comment 4

[Adrian Tamas (:AdrianT)]

Attachment: logs

Comment 5

[Adrian Tamas (:AdrianT)]

Comment on attachment 618590 [details]
logs

Sorry I added the file to the wrong bug.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Bug 727116 describes a change where we will take a snapshot while we pan/zoom, but that's still probably going to be bad for this case. Maybe what we need to do is detect these full page flash applets and not do any of that stuff.

Comment 7

[Tony Chung [:tchung]]

(In reply to Brad Lassey [:blassey] from comment #3)
> snorp will be landing a major change to how we paint flash, so please retest
> once that lands.
> 
> Snorp, can you put the bug number for that in a comment here?

removing qawanted for now.  comment 6 hints that the fix for bug 727116 may not fix this bug.

fwiw, 04-26-2012 nightly, incredible S.  Still reproducing flash flickering today.

Comment 8

[Tony Chung [:tchung]]

A different full flash site is now causing panning to get a the crash from bug 738198.  Should this be duped?

See https://bugzilla.mozilla.org/show_bug.cgi?id=738198#c10 for more details.

Comment 9

[Tony Chung [:tchung]]

Not just full flash anymore.  try a site with flash ads (eg. www.marketwatch.com).   tap on the flash ad, and it continues to flicker.

HTC Sensation, latest-aurora build 4/30/2012, Android 2.3.4

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Snorp, thoughts on this?

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't use placeholder for full page plugins on Android

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't use placeholder for full page plugins on Android

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

The above patch disables the placeholder hack if the plugin is more than 10% of the screen dimension. This seems to make things much happier for me.

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f6e78dfd4a4

Comment 15

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/9f6e78dfd4a4

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 621178 [details] [diff] [review]
Don't use placeholder for full page plugins on Android

[Triage Comment]

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/982ca139a92a

Comment 18

[Catalin Suciu [:csuciu]]

Unable to reproduce on Nightly 15.0a1 (2012-05-22)
                       Aurora 14.0a2 (2012-05-22)
Samsung Galaxy SII (2.3.4)

The full flash sites are not flickering when panning or tapping the screen. (I used http://verdeteacafe.net/ and http://gotmilk.com ). Also the flash ads on other pages (cnn.com, etc..) are working fine.