746745 - [SeaMonkey] Space for moving to next unread doesn't work (JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 2311)

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Karsten Düsterloh]

JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 2311: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]

when hitting space to move to next unread message - and no message switching happens. Obviously, the pref mail.advance_on_spacebar lacks a default value in SeaMonkey.

This is caused by the Thunderbird bug 332151.

Comment 1

[Rahul Abrol]

sorry about that.  you're all undoubtedly more familiar with the code base than i am so i'll leave the patch to you.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/ [Checked in: Comment 5]

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 616902 [details] [diff] [review]
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/
[Checked in: Comment 5]

I _think_ this is okay, but Standard8 is really the person who would know, so I'm redirecting the review request his way.

Thanks,
Blake.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 616902 [details] [diff] [review]
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/
[Checked in: Comment 5]

Looks fine.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 616902 [details] [diff] [review]
(Av1) Move 'mail.advance_on_spacebar' preference from mail/ to mailnews/
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/b8a4823c1ca3