746848 - Create pref for webapps installer dry-run

Status: VERIFIED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

This would be very helpful during tests of other parts of the api (bug 741549) as to not worry about waiting for the actual installation to happen, and possible garbage left in the slave in case a test fails and does not do proper clean-up.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v2

(missed closed paren in previous patch)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 616412 [details] [diff] [review]
Patch v2

nit: I kind of prefer just a getBoolPref call in a try/catch, since it's a little easier to read. Alternatively, use a local variable for the pref name so you can re-wrap the if statement onto only two lines.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/mozilla-central/rev/ac6e651207d3

Comment 4

[Jason Smith [:jsmith]]

Looks like an internal code change. Is there anything from an end-user perspective I can verify here?

Comment 5

[Ed Lee :Mardak]

You can set the pref to confirm that the app doesn't get installed.

Comment 6

[Jason Smith [:jsmith]]

Verified on Win 7 64-bit on Nightly.