Closed
Bug 747102
Opened 12 years ago
Closed 12 years ago
kSmallCommit shouldn't be used, since it doesn't do anything.
Categories
(MailNews Core :: Database, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: Bienvenu, Assigned: Bienvenu)
Details
Attachments
(2 files, 1 obsolete file)
3.79 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
4.38 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
nsIMsgDatabase::kSmallCommit doesn't do anything in mork, so it shouldn't be used, since it's a temptation.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #616687 -
Flags: review?(neil)
Comment 2•12 years ago
|
||
Comment on attachment 616687 [details] [diff] [review] proposed fix (I don't think changing the uuids has any effect, because nobody QIs to them.)
Attachment #616687 -
Flags: review?(neil) → review+
What about the SmallCommit() method that was called as a result of choosing kSmallCommit? Is that still used/needed?
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to :aceman from comment #3) > What about the SmallCommit() method that was called as a result of choosing > kSmallCommit? Is that still used/needed? I don't care so much about the mork method since people are much less likely to try to call that. But it can go away as well from db/mdb and db/mork
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to :aceman from comment #5) > Can I do it here or in a new bug? doing it here is fine...
Assignee | ||
Comment 7•12 years ago
|
||
db and addrbook patch landed here - http://hg.mozilla.org/comm-central/rev/52160eb9efd5
Attachment #617075 -
Flags: review?(dbienvenu)
Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 617075 [details] [diff] [review] patch for removing SmallCommit() can you rev the IID on nsIMdbStore while you're at it? I doubt anyone cares, but technically, we should.
Attachment #617075 -
Flags: review?(dbienvenu) → review+
Comment 10•12 years ago
|
||
Like this?
Attachment #617075 -
Attachment is obsolete: true
Attachment #617563 -
Flags: review?(dbienvenu)
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 617563 [details] [diff] [review] patch for removing SmallCommit() v2 Review of attachment 617563 [details] [diff] [review]: ----------------------------------------------------------------- yes, thx.
Attachment #617563 -
Flags: review?(dbienvenu) → review+
Keywords: checkin-needed
Comment 12•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/33e93567f9f3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•