747270 - [AccessFu] UtterangeGenerator should return string lists in all generator methods

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Just for consistency, if not anything else...

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: UtterangeGenerator should return string lists in all generator methods.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 616829 [details] [diff] [review]
UtterangeGenerator should return string lists in all generator methods.

Review of attachment 616829 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

Nit: Utteran[g/c]eGenerator

Comment 3

[alexander :surkov (:asurkov)]

(In reply to Eitan Isaacson [:eeejay] from comment #0)
> Just for consistency, if not anything else...

until these methods are commented, it's hard to say what consistency you talk about: genForObject returns an array, getForAction returns a string.

Comment 4

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/717b3ea8f842

Comment 5

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/717b3ea8f842