747325 - 'Error parsing template: expected <content> to be first' when opening virtualFolderListDialog.xul

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[Florian Quèze [:florian]]

Each time I open the virtualFolderListDialog.xul dialog, I see this message twice in my error console:
Error parsing template: expected <content> to be first

This message is printed from http://mxr.mozilla.org/comm-central/source/mozilla/content/xul/templates/src/nsXULContentUtils.cpp#498 without any location information, but it seems clear that the problem is something in http://mxr.mozilla.org/comm-central/source/mailnews/base/content/virtualFolderListDialog.xul#74 that the parser dislikes.

Steps to open that dialog:
1. View -> Folders -> Unified
2. Open the context menu of the Inbox special folder, and select "Properties…"
3. Click the "Choose…" button in the dialog that appeared.

Comment 1

[Magnus Melin [:mkmelin]]

WFM over here

Comment 2

[Florian Quèze [:florian]]

I can still reproduce (tested on a Mac debug build).

Comment 3

[:aceman]

Still happening. Maybe it is something from RDF?

Comment 4

[[e-mail]]

There's a duplicate <content> tag in virtualFolderListDialog.xul, only the first child of <conditions> can be <content>, thus the error.

Comment 5

[:aceman]

Attachment: patch

Thanks Neil.

Comment 6

[[e-mail]]

Comment on attachment 716145 [details] [diff] [review]
patch

>+            <member container="?container" child="?member"
>+                    isDeferred="?isDeferred"/>
Well, if you're going to fiddle, I don't think this is necessary. But I don't really want to create a virtual folder just to find out...

Comment 7

[:aceman]

Attachment: patch v2

If that one is to hide deferred accounts in the list, then I have tried it now and with that line removed deferred accounts are still hidden.

Comment 8

[[e-mail]]

Comment on attachment 716211 [details] [diff] [review]
patch v2

OK, r=me based on code inspection.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/33a80322430e