747800 - Fix code causing |Warning: function xyz does not always return a value|

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jim Porter (:squib)]

Attachment: Remove these warnings

There are a bunch of spots in our code that throw |Warning: function xyz does not always return a value|. Let's fix them so as to reduce the messiness in the Error Console. This has been annoying me lately, as I've been trying to fix startup issues in an add-on, and I always have to scroll past this stuff.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 617351 [details] [diff] [review]
Remove these warnings

Review of attachment 617351 [details] [diff] [review]:
-----------------------------------------------------------------

Please can you generate -p patches (showfunc) in future, it helps with locating the functions that you're changing.

Otherwise looks good.

Comment 2

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/076c3f2bbb9b

(And hgrc updated to show functions in diffs.)

Comment 3

[:aceman]

This is great.
If you spot any similar warnings in the Account manager that are not covered in bug 738810, please assign them to me :)

Comment 4

[Florian Quèze [:florian]]

Thanks for fixing this, I'm annoyed too by warnings at startup :-).

I would appreciate being CC'ed to bugs with patches touching chat/, as these also need to be applied to the upstream Instantbird repository.