747872 - Windows constants for js-ctypes (Chrome Workers)

Status: RESOLVED FIXED

(Core :: js-ctypes, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

Attachment: Exporting Windows constants to JS

Companion for bug 739740, but for Windows constants, in particular Windows error values.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 617442 [details] [diff] [review]
Exporting Windows constants to JS

Review of attachment 617442 [details] [diff] [review]:
-----------------------------------------------------------------

This looks mostly fine, but I'd like to look at it again after you fix the other patch.

::: dom/system/OSFileConstants.cpp
@@ +10,5 @@
>  #include "unistd.h"
>  #endif // defined(XP_UNIX)
>  
> +#if defined(XP_WIN)
> +#include "windows.h"

<windows.h> is the typical style.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Exporting Windows constants to JS

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Exporting Windows constants to JS

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfeab3d52e14

Comment 5

[Ryan VanderMeulen [:RyanVM]]

http://mozillamemes.tumblr.com/post/21637966463/yes-i-have-a-condition-that-forces-me-to-insert

...and backed out for Win64 bustage (so far, anyway).
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf8b1f792ce

e:/builds/moz2_slave/m-in-w64/build/dom/system/OSFileConstants.cpp(220) : error C2065: 'INVALID_FILE_HANDLE' : undeclared identifier

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: Exporting Windows constants to JS

Ok Yoric, take a breath, stop using three distinct local repositories, concentrate and stop uploading **** to the nice sheriffs.

Sorry, Ryan.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/94cab3afbf9b

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/94cab3afbf9b