747896 - Remove hardcoded space inserted before success.title.after (accountProvisioner.dtd)

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Stefan Plewako [:stef]]

Originally reported as Aviary.pl bug 4336.

There is hardocoded space inserted before success.title.after label which is problematic when one wants to use sth like comma after login name. (affects l10n and en-US)

http://bugs.aviary.pl/attachment.cgi?id=2042

Comment 1

[:aceman]

The sentence is like this:
&success.title.before;<FirstName> <LastName>&success.title.after; .
The order and also the space is hardcoded.
Have you left FirstName or LastName blank when you created the account?
The whole string could probably be refined into one string with a placeholder for the name so that localizers can play with the position. Were this not in some jquery code I could probably do it.

Comment 2

[Stefan Plewako [:stef]]

I don't see FirstName and LastName fields on fresh start or when getting new account…
I only see one field, "Your name, or nickname" with search button on the right.

Comment 3

[:aceman]

Maybe that is the problem.

Comment 4

[:aceman]

OK, I tested it and I can confirm the problem.

The input box placeholder text says "Your name, or nickname". But the code of the dialog in several places splits the input text into a firstName and lastName. And then it often contatenates them together with a space so that if lastname is empty a trailing space will remain.

Comment 5

[:aceman]

Attachment: patch

The attached patch removes the potential trailing space (via .trim) in two places. It does not change the logic wrt. the existing code already coping with empty last name.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 617530 [details] [diff] [review]
patch

Review of attachment 617530 [details] [diff] [review]:
-----------------------------------------------------------------

This looks right to me.

Thanks aceman!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/968ca62d7854