Closed
Bug 748223
Opened 12 years ago
Closed 12 years ago
Pack nsEditor better
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
7.13 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
I have a patch which reduces sizeof(nsEditor) from 296 to 280 on 64-bit platforms.
Assignee | ||
Comment 1•12 years ago
|
||
http://tbpl.mozilla.org/?tree=Try&rev=4f2154cdaebf
Comment 2•12 years ago
|
||
How many nsEditor objects are we likely to have live at once?
Comment 3•12 years ago
|
||
Try run for 4f2154cdaebf is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=4f2154cdaebf Results (out of 73 total builds): success: 56 warnings: 7 failure: 10 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-4f2154cdaebf
Attachment #617780 -
Flags: review?(roc) → review+
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #2) > How many nsEditor objects are we likely to have live at once? Currently, one per textarea element on the page, one per <input type=text> if you've interacted with them (by focusing/typing/etc) or if the page script does some special things (because the nsEditor for those are initialized lazily), one per any text box in XUL documents, and one per HTML document which has an editable section.
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/3e6ca2158274
Target Milestone: --- → mozilla15
Assignee | ||
Comment 6•12 years ago
|
||
And backed out, since we treat warnings as errors!
Assignee | ||
Comment 7•12 years ago
|
||
Relanded: https://hg.mozilla.org/projects/birch/rev/e1f732215854
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e1f732215854
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•