748240 - "view-source:" doesn't load HTML from AppCache

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Step to reproduce:

1. Go to a AppCache enabled website, make sure it's cached
2. Verified it is AppCache'd by checking about:cache?device=offline
3. Delete the HTTP cache (Preference -> Advanced -> Network -> Cached Web Content -> Clear Now)
4. Go offline (File -> Work Offline)
5. Go back to the website, it should load from AppCache
6. View source (cmd+U)

Expected result:

* view the source code

Actual result:

* Problem loading page

==

It's very tricky to reproduce the behavior in Firefox, but in B2G Gaia we test our apps by inserting offline AppCache directly into the profile with a fictitious hostname, that makes the behavior easy to surface (with the view source hardware key from in our dev preview phone)

Is it possible to make view-source to access not only HTTP cache but also AppCache?

Comment 1

[Boris Zbarsky [:bzbarsky]]

No, this was in the right place.  Necko is what's not hitting the appcache here.  The toolkit code is just using the APIs core exposes for this stuff.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Boris Zbarsky (:bz) from comment #1)
> No, this was in the right place.  Necko is what's not hitting the appcache
> here.  The toolkit code is just using the APIs core exposes for this stuff.

Oh thanks.

Comment 3

[Honza Bambas (:mayhemer)]

I'll look at this.  I suspect this may be complicated, though...

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: v1

It was damn easy! :)  Just let nsViewSourceChannel implement and forward nsIApplicatonCacheChannel.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 623113 [details] [diff] [review]
v1

r=me

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 623113 [details] [diff] [review]
v1

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5023518db2f

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c5023518db2f

Comment 8

[Matt Brubeck (:mbrubeck)]

This patch may have triggered a new intermittent leak in mochitests (bug 754588).  Any thoughts on whether or how that might be related?