748473 - Android back button doesn't work anymore

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Shell Integration, defect)

Description

[Mike Hommey [:glandium]]

It stopped working a few nightlies ago.

(using xul/tablet nightly on Asus Transformer TF101 under ICS, if that matters)

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

XUL Nightly (14) isn't going to ship I think, though?  I could be mistaken.

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to Naoki Hirata :nhirata from comment #1)
> XUL Nightly (14) isn't going to ship I think, though?  I could be mistaken.

We plan to ship it on the beta channel at least, for tablets.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

OH. good point.

Comment 4

[Matt Brubeck (:mbrubeck)]

I can reproduce this.  Nominating for tracking-firefox14 because this will be a blocker for releasing Firefox 14 beta for tablets.

Comment 5

[Bill Gianopoulos [:WG9s]]

Regression window is between the 4/20 and 4/21 nightlies:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=22bfdebf5cae&tochange=021f95903ded

I will try to find time to isolate further using hg bisect tomorrow.

Comment 6

[Matt Brubeck (:mbrubeck)]

Thanks. Looks like a regression from https://hg.mozilla.org/mozilla-central/rev/a6dd3218bf6a (bug 742036), which removed code to map KEYCODE_BACK to NS_VK_ESCAPE;

Comment 7

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to Matt Brubeck (:mbrubeck) from comment #7)
> Created attachment 618085 [details] [diff] [review]
> patch

This patch fixes the issue for me and is now included in my builds available at http://www.wg9s.com/mozilla/firefox/

Comment 9

[Bill Gianopoulos [:WG9s]]

Just my opinion, but I think the severity of this needs to be higher.

Comment 10

[Bill Gianopoulos [:WG9s]]

I should have explained.  Form either the Add-ons page or the about:fennec page, there does not seem to be a way to actually get back to browsing without killing via task manager and restarting.

Comment 11

[Chris Peterson [:cpeterson]]

Comment on attachment 618085 [details] [diff] [review]
patch

Review of attachment 618085 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with updated comments.

::: widget/android/nsWindow.cpp
@@ +1624,5 @@
>      }
>  
>      switch (androidKeyCode) {
>          // KEYCODE_UNKNOWN (0) ... KEYCODE_POUND (18)
> +        case AndroidKeyEvent::KEYCODE_BACK:               return NS_VK_ESCAPE;

Since KEYCODE_BACK falls within the missing KEYCODE_UNKNOWN -> KEYCODE_POUND range, I think the comments should be updated to indicate the new missing keycode ranges:

    // KEYCODE_UNKNOWN (0) ... KEYCODE_HOME (3)
    case AndroidKeyEvent::KEYCODE_BACK: return NS_VK_ESCAPE;
    // KEYCODE_CALL (5) ... KEYCODE_POUND (18)

Comment 12

[Chris Peterson [:cpeterson]]

Comment on attachment 618085 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 742036
User impact if declined: XUL Fennec's Back button won't work!
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Not risky.
String changes made by this patch: None

Comment 13

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b962ffec138

Comment 14

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/3b962ffec138

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 618085 [details] [diff] [review]
patch

[Triage comment]
Please go ahead and land to Aurora (Firefox 14)

Comment 16

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9bafe6b61d91

Comment 17

[Aaron Train [:aaronmt]]

Verified fixed with 14.0 Beta 6 on XF