748498 - Sites can be updated with wrong title

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:

1) Go to some page (I use about:home)
2) Open a site that takes a few seconds to load. An easy one is http://people.mozilla.com/~bnicholson/test/loop.html (warning: will hang Firefox for 5 seconds).
3) While it's loading, push the back button.
4) Look at the page in the AwesomeScreen.

Expected result:
Page will either have no title or the correct title.

Actual result:
Page's title changed to the previous page - in this case, "Fennec Start".

I was able to reproduce this on a number of sites (Google search, Zimbra, and the link given above).

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch

Following this sequence of events:
* Load about:home
* Load slow page
* Click back during load

we can apparently get a DOMContentLoaded event for the slow page *after* we receive a document start event for about:home. This patch makes sure we match titles with their correct page URLs in these cases.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 618094 [details] [diff] [review]
patch

IRL we talked about not changing updateTitle and just testing in the handleTitleChanged and handleContentLoaded.

It doesn't feel right to add pass the url to updateTitle for checking internally.

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: patch v2

If we set the URL on location change, we don't have to worry about setting the tab URL too early (which means we don't need to worry about events being out of sync with the tab state).

Comment 4

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5728d1210dbe

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5728d1210dbe

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 618757 [details] [diff] [review]
patch v2

[Approval Request Comment]
Regression caused by (bug #): bug 746380
User impact if declined: page may be saved in history with wrong title
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low risk
String changes made by this patch: none

Comment 7

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/c8c0e9faf33a

Comment 8

[Alfredos-Panagiotis Damkalis [:fredy]]

I verify that this bug is fixed on beta version (v14).

Comment 9

[Paul Feher]

The issue is not reproducible anymore on:
Nightly Fennec 15.0a1 (2012-05-22)
Aurora Fennec 14.0a2 (2012-05-22)
Device: HTC Desire Z
OS: Android 2.3.3

Using the STR from comment 0. There is no title in the AwesomeScreen.