748725 - nsINode::GetParentElement() should return dom::Element*

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Currently it returns nsINode*, so callers can't use nsIContent or dom::Element methods.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch v1

This compiles on my machine, and passes the test for bug 685798.  I doubt it will cause any test failures, but as usual, you can wait for the try run to finish if you like.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 618212 [details] [diff] [review]
Patch v1

Thanks.

Comment 3

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 618212
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=b08202fd81c5
Try run started, revision b08202fd81c5. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64fe2f3a7465

Comment 5

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/64fe2f3a7465

Comment 6

[Mozilla RelEng Bot]

Try run for b08202fd81c5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b08202fd81c5
Results (out of 110 total builds):
    exception: 18
    success: 74
    warnings: 18
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b08202fd81c5
 Timed out after 12 hours without completing.