749156 - Failure in /testPasswordManager/testPasswordNotificationBar.js | Expression "id("password-save-notification")" returned null. Anonymous == false

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Alex Lakatos[:AlexLakatos]]

TEST: /testPasswordManager/testPasswordNotificationBar.js::testPasswordNotification
ERROR: Expression "id("password-save-notification")" returned null. Anonymous == false 
WHEN: 2012-04-25
FIRST: 2012-04-25
FREQ: 3
BRANCHES: default

Something changed in popup-notification creation in Firefox.
On previous versions an element with id "password-save-notification" got created and after closing, still remained in the xul file. Not it is removed.

Comment 1

[Alex Lakatos[:AlexLakatos]]

Attachment: patch v1.0 [checked-in:default,aurora,beta]

The test referenced the parentNode of the password notification. So I got the parent node directly, without referenced it via the child, since that gets removed.

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

Comment on attachment 618634 [details] [diff] [review]
patch v1.0 [checked-in:default,aurora,beta]

Please pass reviews to Henrik from now on and keep Anthony for feedback requests, as of today. 

This is due to a 1 on 1 chat I had with Anthony yesterday on iRC. Thanks for the patch Alex!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Maniac Vlad Florin (:vladmaniac) from comment #2)
> Please pass reviews to Henrik from now on and keep Anthony for feedback
> requests, as of today. 

No, that's not only me. It will be everyone from the Automation Developer team. As for now Dave and me. So please split it up between us.

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/9e935620e762

Please check if it fixes the failure and also land on aurora today.

Comment 4

[u279076]

Comment on attachment 618634 [details] [diff] [review]
patch v1.0 [checked-in:default,aurora,beta]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/268ef8d52d34 (mozilla-aurora)

Comment 5

[u279076]

Verified this did not fail today on Nightly.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Anthony, please use the new status fields to mark where a patch has been checked in. Thanks.

Comment 7

[u279076]

Comment on attachment 618634 [details] [diff] [review]
patch v1.0 [checked-in:default,aurora,beta]

I noticed this failure happening on Beta so I landed the patch:

http://hg.mozilla.org/qa/mozmill-tests/rev/fb18a4382b34 (mozilla-beta)

See:
http://mozmill-ondemand.blargon7.com/#/functional/report/c2b72632f20450b6d99d14c709b017e5

Comment 8

[Andreea Matei [:AndreeaMatei]]

This happened again today with Linux, on the new Nightly and PB mode:
http://mozmill-ci.blargon7.com/#/functional/failure?branch=All&platform=All&from=2012-12-14&to=&test=%2FtestPasswordManager%2FtestPasswordNotificationBar.js&func=testPasswordNotificationBar.js%3A%3AtestPasswordNotification

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please do not reopen a bug which has been fixed a long time ago. The new failure is totally disconnected from the old issue we had to fix here. Please file a new bug for.