749215 - toolkit/devtools/debugger/Makefile.in should install debugger JSMs as symlinks for development

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jim Blandy :jimb]

Attachment: Install the debug server jsms as symlinks, when appropriate.

At the moment, the debugger Makefile.in copies the JSMs in toolkit/devtools/debugger and toolkit/devtools/debugger/server into dist/bin/modules/devtools. It should symlink them in, to make development easier.

Comment 1

[Jim Blandy :jimb]

https://tbpl.mozilla.org/?tree=Try&rev=a862405cfb7b

Comment 2

[Jim Blandy :jimb]

Note that the "ac_add_options --enable-chrome-format=symlink" doesn't provide this functionality. I'm not sure why, but those JSMs aren't installed in the same way as the .js files.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 618663 [details] [diff] [review]
Install the debug server jsms as symlinks, when appropriate.

ok!

Comment 4

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/fx-team/rev/41e7d93533c1

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/41e7d93533c1

Comment 6

[Jim Blandy :jimb]

Talos sent me email claiming that I'd regressed performance. I wept for several days, but then gathered my wits about me and looked at this chart:

http://graphs-new.mozilla.org/graph.html#tests=[[196,64,21]]&sel=none&displayrange=30&datatype=running

and decided that my commit, on May 1st, was not responsible for the regression.

Comment 7

[Rob Campbell [:rc] (:robcee)]

there there, jim. Talos can't hurt you anymore.