749533 - SkAdvancedTypefaceMetrics.cpp:19:52: fatal error: ApplicationServices/ApplicationServices.h: No such file or directory on Hurd and kFreeBSD

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add support for GNU/kFreeBSD and Hurd in SKIA

I'll check if more is needed.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add support for GNU/kFreeBSD and Hurd in SKIA

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 619001 [details] [diff] [review]
Add support for GNU/kFreeBSD and Hurd in SKIA

I worry that this relies on GLIBC not being used by unrelated operating systems. Did you mean (defined(__GLIBC__) && defined(__GNU__)) instead ?

Comment 4

[Mike Hommey [:glandium]]

(In reply to Benoit Jacob [:bjacob] from comment #3)
> Comment on attachment 619001 [details] [diff] [review]
> Add support for GNU/kFreeBSD and Hurd in SKIA
> 
> I worry that this relies on GLIBC not being used by unrelated operating
> systems. Did you mean (defined(__GLIBC__) && defined(__GNU__)) instead ?

GLIBC is what provides the "unix" libc. Whatever kernel it runs on will thus expose the libc functions. It so happens that GNU/kfreeBSD is such a system: it has the glibc, and uses a FreeBSD kernel. Its compiler defines __GLIBC__. GNU/Hurd, however, while it comes with glibc (obviously), doesn't define __GLIBC__. It defines __GNU__ instead.

So we need to check for both, individually.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2408bf119fbf

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2408bf119fbf