749548 - IEProfileMigrator.js and SafariProfileMigrator.js are always in the components manifest

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Mike Hommey [:glandium]]

On Mac, there is no IEProfileMigrator.js.
On Linux, there is neither.

Yet, in both builds, they both are in the components manifest.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Only reference IE and Safari migrators in components manifest when they are installed

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed

Review of attachment 618955 [details] [diff] [review]:
-----------------------------------------------------------------

should be safe to backport to 13 too, so please get approval and do :)

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9150ab0f7bea

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/9150ab0f7bea

Comment 5

[Matthew N. [:MattN]]

The commit message is misleading because we can't detect "when they are installed" at build time. Something like this would be better:
"Only reference IE and Safari migrators in components manifest on supported operating systems."

Comment 6

[Mike Hommey [:glandium]]

It's "installed" in the "$(NSINSTALL)" sense.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Marco Bonardo [:mak] from comment #2)
> should be safe to backport to 13 too, so please get approval and do :)

I actually meant "backport to 14"... Merge didn't help my numbering.

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed

[Approval Request Comment]
Regression caused by: bug 710259 and bug 710895
User impact if declined: No real user impact, but Firefox uselessly tries to registers components that aren't there on Mac and Linux.
Testing completed (on m-c, etc.): Landed on m-c a couple days ago.
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 618955 [details] [diff] [review]
Only reference IE and Safari migrators in components manifest when they are installed

[Triage Comment]
We don't typically take correctness fixes with no user impact.