Closed
Bug 749563
Opened 12 years ago
Closed 12 years ago
Consumed Alt key (i.e., preventDefault() is called) causes to activate menubar
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: masayuki, Assigned: masayuki)
References
()
Details
Attachments
(1 file)
5.23 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
1. Open the URL. 2. Press Alt key. Then, the Alt keydown event is consumed by the blank page, but menu is activated. It shouldn't be activated by consumed event. Alt+F works fine, it checks the defaultPrevented value.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #622238 -
Flags: review?(enndeakin)
Comment 2•12 years ago
|
||
Comment on attachment 622238 [details] [diff] [review] Patch >+ result: function(testname) { >+ ok(!document.getElementById("filemenu").openedWithKey, testname); >+ }, Could you also add a line to check that the menu isn't open, so that an test failure will be caught here rather than at a later test. Same with the other test.
Attachment #622238 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e52bf88f2f54
Target Milestone: --- → mozilla15
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e52bf88f2f54
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Flags: in-testsuite+
Updated•5 years ago
|
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•