749573 - "make install" doesn't install xpcshell and run-mozilla.sh in the SDK

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

bug 743560 made them part of the SDK instead of xulrunner. make make-sdk ships them, but make install doesn't.

As a side note, run-mozilla.sh is not shipped in xulrunner, maybe it shouldn't be shipped in Firefox either.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Declare run-mozilla.sh and xpcshell as SDK_BINARY

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/879fd99f199c

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/879fd99f199c

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 618992 [details] [diff] [review]
Declare run-mozilla.sh and xpcshell as SDK_BINARY

[Approval Request Comment]
Regression caused by: bug 743560 
User impact if declined: People using make install (mostly, Linux distros) won't have run-mozilla.sh and xpcshell installed with SDK.
Testing completed (on m-c, etc.): Landed on m-c a couple days ago.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 618992 [details] [diff] [review]
Declare run-mozilla.sh and xpcshell as SDK_BINARY

[Triage Comment]
Low risk fix in support of local builds.

Comment 6

[Mike Hommey [:glandium]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/f9241d246616