Closed
Bug 749589
Opened 12 years ago
Closed 12 years ago
Less-leaky classinfo for XTF
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(1 file)
5.47 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Classinfo shouldn't keep the object alive.
Assignee | ||
Comment 2•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 619016 [details] [diff] [review] WIP Bill, could you test this? It should fix the leak you saw where keeping classinfo alive ends up keeping element alive.
Attachment #619016 -
Flags: review?(jst)
Attachment #619016 -
Flags: feedback?(wmccloskey)
Assignee | ||
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=1e3e3ac9452f
Assignee | ||
Comment 5•12 years ago
|
||
Jst, review ping. I believe this block iGC.
Comment 6•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #5) > Jst, review ping. I believe this block iGC. No, it doesn't. This is just an existing leak that we've ignored for years that Bill happened to notice while investigating IGC leaks, if I understand correctly.
Assignee | ||
Comment 7•12 years ago
|
||
Oh, I thought iGC+xpcshell tests were leaking because of this. But anyhow, Bill, you could test this.
Assignee | ||
Comment 8•12 years ago
|
||
er, could you...
(In reply to Olli Pettay [:smaug] from comment #7) > Oh, I thought iGC+xpcshell tests were leaking because of this. They are, but non-iGC+xpcshell are too :-)
Yeah, this fixes the leak. Thanks. This doesn't block IGC. It's a leak we found while trying to debug the IGC leak. As Rafael said, it leaks on trunk right now.
Updated•12 years ago
|
Attachment #619016 -
Flags: review?(jst) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #619016 -
Flags: feedback?(wmccloskey)
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/22a58090fa70
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•