Closed Bug 749720 Opened 12 years ago Closed 12 years ago

mozharness multilocale will detect missing tags, but not fail out

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

(Whiteboard: [mozharness])

Attachments

(1 file, 1 obsolete file)

This is probably fine for 10.0.4esr, but we should catch this going forward.
Blocks: 749542
Attached patch this should do it (obsolete) — Splinter Review
Tested using:

# Good revision
mozharness/scripts/hgtool.py -r default http://hg.mozilla.org/build/tools

# Bad revision
mozharness/scripts/hgtool.py -r defaultblah http://hg.mozilla.org/build/tools

The latter fatal()s out.

Also, feeling guilty for sending so many reviews your way.
Attachment #619161 - Attachment is obsolete: true
Attachment #620435 - Flags: review?(rail)
Comment on attachment 620435 [details] [diff] [review]
only fatal() on return code != 0

(In reply to Aki Sasaki [:aki] from comment #2)
> Also, feeling guilty for sending so many reviews your way.

anytime!
Attachment #620435 - Flags: review?(rail) → review+
Comment on attachment 620435 [details] [diff] [review]
only fatal() on return code != 0

http://hg.mozilla.org/build/mozharness/rev/ea1d9f46c6ca
Attachment #620435 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: