749795 - Getter for NPNVprivateModeBool is broken with OOPP

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Matthews [:jdm]]

I'm glad I decided to add a test for bug 748752, since it exposed that the code is completely broken. Retrieving the document (http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsNPAPIPlugin.cpp#2139) fails, since npp is null (http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/PluginModuleParent.cpp#978). Josh, what's the correct way to fix this?

Comment 1

[Josh Matthews [:jdm]]

It looks like the privateModeBool handling will need to move to PluginInstance*, similar to pluginElementNPObject and pluginWindowNPObject.

Comment 2

[Josh Matthews [:jdm]]

Attachment: Use neglected code that properly obtains private browsing mode in plugins.

That was easy. The test now passes.

Comment 3

[Josh Aas]

Comment on attachment 619505 [details] [diff] [review]
Use neglected code that properly obtains private browsing mode in plugins.

Review of attachment 619505 [details] [diff] [review]:
-----------------------------------------------------------------

Did you intend to include the change to test_domstorage_aboutpages.js?

Comment 4

[Josh Matthews [:jdm]]

Nein. I'll take that out when landing.

Comment 5

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/52abbd73ec2d

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/52abbd73ec2d