750063 - Allow passing null to nsTextEditRules::CreateMozBR's outparam

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Most callers don't want the return value, so it makes more sense not to require keeping a local pointer around for it.

Comment 1

[(no longer active)]

Comment on attachment 619394 [details] [diff] [review]
Patch v1

Review of attachment 619394 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/text/nsTextEditRules.h
@@ +226,5 @@
>    /** Remove IME composition text from password buffer */
>    nsresult RemoveIMETextFromPWBuf(PRUint32 &aStart, nsAString *aIMEString);
>  
> +  nsresult CreateMozBR(nsIDOMNode* inParent, PRInt32 inOffset,
> +                       nsIDOMNode** outBRNode = NULL);

Nit: nsnull

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/3859550a1cbb