750191 - move IsTextInterfaceSupportCorrect under DEBUG ifdef

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

IsTextInterfaceSupportCorrect is under DEBUG_A11Y, move all related pieces to DEBUG ifdef.

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Small technical change patch....

Comment 2

[Hubert Figuiere [:hub]]

Comment on attachment 621343 [details] [diff] [review]
Patch (v1)

looks good.

but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp

Comment 3

[Mark Capella [:capella]]

Attachment: Patch (v2)

Thanks! Not sure how I missed that during my scan ...

New patch, builds and mochitests ok locally ...

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Hub Figuiere [:hub] from comment #2)

> but I see one missing in accessible/src/xul/nsXULMenuAccessible.cpp

I wasn't sure about this one (not it's not covered by bug summary) but if you want to take it in then it's fine with me I think.

Comment 5

[alexander :surkov (:asurkov)]

Mark, it'd be great if you start try server build before asking for review to make sure you don't have compilation errors (in case if you don't do that). This one produces errors https://tbpl.mozilla.org/php/getParsedLog.php?id=11528704&tree=Try&full=1#error0. I'll fix them before landing.

Comment 6

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7bea577a43

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9b7bea577a43