750193 - get rid useless DEBUG_A11Y code

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

1) http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHTMLTableAccessible.cpp#1300 since the code is under SHOW_LAYOUT_HEURISTIC ifdef
2) http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessNode.cpp#95 - just handing piece of code
3) http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsDocAccessible.cpp#1770 - you can do that by DOMi tool

Comment 1

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov from comment #0)
> 1)
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/
> nsHTMLTableAccessible.cpp#1300 since the code is under SHOW_LAYOUT_HEURISTIC
> ifdef

remove ifdefs

> 2)
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/
> nsAccessNode.cpp#95 - just handing piece of code
> 3)
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/
> nsDocAccessible.cpp#1770 - you can do that by DOMi tool

remove entire blocks

Comment 2

[Max Li [:maxli]]

Attachment: Patch v1

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 619765 [details] [diff] [review]
Patch v1

Review of attachment 619765 [details] [diff] [review]:
-----------------------------------------------------------------

This is good. Thanks!

I am assuming that this bug is only for those 3 files and not for getting rid of DEBUG_A11Y over all. If it is, then another bug should be opened.

Comment 4

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24f9b828d28a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/24f9b828d28a