Closed
Bug 750196
Opened 12 years ago
Closed 12 years ago
remove ROLE_SYSTEM_ definitions
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: surkov, Assigned: maxli)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][mentor=eitan@monotonous.org][lang=c++])
Attachments
(1 file)
|
1.14 KB,
patch
|
eeejay
:
review+
|
Details | Diff | Splinter Review |
they were introduced in 2006 to fix tbox bustage (http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/accessible/src/msaa&command=DIFF_FRAMESET&file=nsRoleMap.h&rev2=1.2&rev1=1.1), I don't think we need them nowdays
|
Reporter | |
Comment 1•12 years ago
|
||
they are in msaa/nsAccessibleWrap.cpp
|
||
Comment 2•12 years ago
|
||
VC7.1 has them, but VC6 didn't.
|
|
Reporter | |
Comment 3•12 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #2) > VC7.1 has them, but VC6 didn't. ok, thank you. so we are on safe side then: vc6 is not officially supported for trunk (https://developer.mozilla.org/En/Developer_Guide/Build_Instructions/Windows_Prerequisites)
|
Assignee | |
Comment 4•12 years ago
|
||
Assignee: nobody → maxli
Attachment #619806 -
Flags: review?(eitan)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 619806 [details] [diff] [review] Patch v1 Review of attachment 619806 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks!
Attachment #619806 -
Flags: review?(eitan) → review+
|
|
Reporter | |
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03ca8a717fd4
Target Milestone: --- → mozilla15
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03ca8a717fd4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•