75022 - nsSHistory::GoBack/Forward's check is redundant

Status: VERIFIED WONTFIX

(Core :: DOM: Navigation, defect)

Description

[Blake Ross]

nsSHistory::GoBack (and its Forward counterpart) calls nsSHistory::GetCanGoBack 
before going back.  This seems a bit like a waste, because we have a canGoBack 
broadcaster that ensures that the user can't go back anyways (by updating the 
UI appropriately).  Is it better to force people to call GetCanGoBack first, or 
should they be allowed to just call GoBack unequivocably, which then checks 
implicitly?

Comment 1

[Radha on family leave (not reading bugmail)]

I think GoBack() calling CanGoBack() is OK. The browser is not the only client 
to the SH. Some embedding applications may not choose to call CanGoback() and 
expect SH to do the job for them. I'm going to leave the code as it is.

Comment 2

[Alec Flett]

I have to agree with radha on this one - what happens if an embedder calls
GoBack() when we're not allowed to go back.. we shouldn't barf, so we should
call CanGoBack()

Comment 3

[Radha on family leave (not reading bugmail)]

There is no bug here.

Comment 4

[sairuh (rarely reading bugmail)]

mass-verifying WontFix bugs which haven't changed since 2001-12-31.

use the search string "BoletusEdulis" if you want to filter out this msg.