750698 - Reader Mode: Implement "read now" action

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

General design involves:
- Showing a "Read now" button on browser toolbar. Initial idea is to show a book-like icon on the right size.
- When "Read now" is tapped, the page is changed into readable style.

See design page for reference:

  https://wiki.mozilla.org/Fennec/NativeUI/UserExperience/ReaderMode

Need assets for the button.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Attachment: assets

Comment 2

[Patryk Adamczyk [:patryk] UX]

Attachment: assets

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Add simpler loadUrl method to load page in current tab

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Implement "reader mode" action

We might change this to load DOM document from the existing tab directly once we start using the chromeless GeckoApp thingy that Wes is working on. For now, it's saner to just load the article in the same tab from the URL.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 631337 [details] [diff] [review]
Add simpler loadUrl method to load page in current tab

Do we really need this simplification?

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> Comment on attachment 631337 [details] [diff] [review]
> Add simpler loadUrl method to load page in current tab
> 
> Do we really need this simplification?

Strictly speaking, no. But it didn't feel right to use AwesomeBar* bits inside Tab. Maybe Target should really be in GeckoApp instead?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lucas Rocha (:lucasr) from comment #6)
> (In reply to Mark Finkle (:mfinkle) from comment #5)
> > Comment on attachment 631337 [details] [diff] [review]
> > Add simpler loadUrl method to load page in current tab
> > 
> > Do we really need this simplification?
> 
> Strictly speaking, no. But it didn't feel right to use AwesomeBar* bits
> inside Tab. Maybe Target should really be in GeckoApp instead?

Ah, I see what you mean. Yeah, the simplification is OK for not coupling AwesomeBar into more code. Maybe we should move Target into GeckoApp, or somewhere else, to reduce the coupling.

Comment 8

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/de917daa32d6
http://hg.mozilla.org/integration/mozilla-inbound/rev/09ff9a7af93e

Comment 9

[Lucas Rocha (:lucasr)]

Comment on attachment 631337 [details] [diff] [review]
Add simpler loadUrl method to load page in current tab

Reader Mode is tentatively planned for Firefox 15. It's still disabled and invisible to users. Need to keep landing it in aurora and central.

Comment 10

[Lucas Rocha (:lucasr)]

Comment on attachment 631338 [details] [diff] [review]
Implement "reader mode" action

Reader Mode is tentatively planned for Firefox 15. It's still disabled and invisible to users. Need to keep landing it in aurora and central.

Comment 11

[Alex Keybl [:akeybl]]

(In reply to Lucas Rocha (:lucasr) from comment #10)
> Comment on attachment 631338 [details] [diff] [review]
> Implement "reader mode" action
> 
> Reader Mode is tentatively planned for Firefox 15. It's still disabled and
> invisible to users. Need to keep landing it in aurora and central.

Has uplifting Reader Mode to FN15 been requested by the product team?

Comment 12

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/de917daa32d6
https://hg.mozilla.org/mozilla-central/rev/09ff9a7af93e

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 631337 [details] [diff] [review]
Add simpler loadUrl method to load page in current tab

[Triage Comment]
Reader mode is not slated for FF15 in the current draft of the product roadmap.