750960 - OMTC: Qt AppShell should use CurrentThread object for event dispatching

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

Currently nsAppShell dispatcher using qApp->thread() as thread for events dispatching, which is wrong for embedding OMTC setup where we might have qApp in embedding UI thread. and gecko working in different QEventLoop.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Use QThread::currentThread for events dispatcher

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 620139 [details] [diff] [review]
Use QThread::currentThread for events dispatcher

Review of attachment 620139 [details] [diff] [review]:
-----------------------------------------------------------------

how did this work before?  we were processing events on the wrong thread?

Comment 3

[Oleg Romashin (:romaxa)]

default builds are single thread, so AppShell and qApplication working in same thread... also qt main loop with glib backend handle these isssues.
this is basically causing problem only with OMTC embedding where qApplication main and appshell work in different threads

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6df779e244c3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6df779e244c3