Closed Bug 751035 Opened 12 years ago Closed 12 years ago

Remove various unused nsHTML*Element related methods

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla15

People

(Reporter: ehren.m, Assigned: ehren.m)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 2 obsolete files)

patch for checkin
25.06 KB, patch
ehren.m
: review+
RyanVM
: checkin+
Details | Diff | Splinter Review 
Built on Linux without issue. None of these are scriptable.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #620189 -
        Flags: review?(jst)

    
    

    
  
Johnny, feel free to bounce the review to me if needed.
Version: unspecified → Trunk

    
    

    
  
Comment on attachment 620189 [details] [diff] [review]
patch

Nice dead code removal! The one thing that should be changed here before this lands is that we should update the IID of nsITextControlElement. Other than that this looks great! Thanks for the patch!

        Attachment #620189 -
        Flags: review?(jst) → review+

    
    

    
  


  
now with updated IID for nsITextControlElement (carrying over r=jst)

        Attachment #620189 -
        Attachment is obsolete: true

        Attachment #622527 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  
oops, last patch should have used a 2 space, not 4 space, indent for the 2nd line of the IID. Here's a fix. (carrying over r+ again)

        Attachment #622527 -
        Attachment is obsolete: true

        Attachment #622542 -
        Flags: review+

    
    

    
  
...I literally was updating the bug with the checkin commit when I mid-aired with you.
https://hg.mozilla.org/integration/mozilla-inbound/rev/82853146de86

Please post a follow-up patch rebased on top.
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15

        Attachment #622527 -
        Attachment is obsolete: false

        Attachment #622527 -
        Flags: checkin+

        Attachment #622542 -
        Attachment is obsolete: true

    
    

    
  
Sorry about that Ryan!

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: