Closed
Bug 751227
Opened 12 years ago
Closed 12 years ago
Remove nsPresShell::mStackArena, make it a separate stack class
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
(Whiteboard: [MemShrink])
Attachments
(1 file, 1 obsolete file)
26.79 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
nsPresShell::mStackArena takes up a lot of space permanently even though it's only used as temporary storage in a couple of XUL layout methods. Before this patch, sizeof(nsPresShell) is 552 making jemalloc allocate a 1024 byte block for it. Additionally, mStackArena is a 4096 block even when it's not actually used. (This is on 64-bit Linux) With the patch, sizeof(nsPresShell) is 512, fitting exactly into a 512 jemalloc chunk. mStackArena is removed, so the total saving is 4.6kB.
Assignee | ||
Comment 1•12 years ago
|
||
The StackArena/StackBlock/StackMark code is verbatim copies, except that I made StackArena completely private and AutoStackArena a friend to forbid any direct use of StackArena.
Attachment #620361 -
Flags: review?(roc)
Assignee | ||
Comment 2•12 years ago
|
||
I'm not sure the two places where this code is used really justifies its existence. The only benefit I see is that it coalesces the alloc/free of (presumably) many small objects, and it avoids the realloc copying in nsTArray f.e. should we use that instead. Do we have some collection type that use "roped" multiple buffers internally to avoid copying?
Assignee | ||
Comment 3•12 years ago
|
||
> in a couple of XUL layout methods
One XUL and one Table layout method, actually.
Assignee | ||
Comment 4•12 years ago
|
||
Try results pending, together with bug 750745 patches: https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=272574ed8c60
Updated•12 years ago
|
Whiteboard: [MemShrink]
Assignee | ||
Comment 5•12 years ago
|
||
> Before this patch, sizeof(nsPresShell) is 552 ... (This is on 64-bit Linux)
Uhm, a Linux64 debug build to be exact, so the clown shoes on nsPresShell
is likely less of a problem in release builds, I'll check what the real
numbers are. The 4096 bytes mStackArena size should be accurate though --
those structs does not have DEBUG-only members.
Assignee | ||
Comment 6•12 years ago
|
||
FYI, I found bug 486066 with discussion about removing the StackArena class.
Comment on attachment 620361 [details] [diff] [review] fix Review of attachment 620361 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! ::: layout/base/StackArena.h @@ +87,5 @@ > + return mStackArena->Allocate(aSize); > + } > + > +private: > + static StackArena* mStackArena; gStackArena ::: layout/tables/SpanningCellSorter.h @@ +76,5 @@ > */ > Item* GetNext(PRInt32 *aColSpan); > private: > nsIPresShell *mPresShell; > + mozilla::AutoStackArena mArena; Putting this in the class is a bit dangerous because it permits non-stack behavior. How about moving it to a local variable in some function?
Assignee | ||
Comment 8•12 years ago
|
||
Doesn't NS_STACK_CLASS on SpanningCellSorter take care of that? AutoStackArena should probably have NS_STACK_CLASS too, but I wasn't sure if all compilers would grok that.
I think I'd rather have NS_STACK_CLASS on AutoStackArena and put it explicitly in a method's stack frame.
Assignee | ||
Comment 10•12 years ago
|
||
Nits fixed. https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=e21455c5646f
Attachment #620361 -
Attachment is obsolete: true
Attachment #620361 -
Flags: review?(roc)
Attachment #620762 -
Flags: review?(roc)
Assignee | ||
Comment 11•12 years ago
|
||
The size of nsPresShell in an Opt build on Linux64: before: sizeof=496 moz_malloc_size_of=504 after: sizeof=456 moz_malloc_size_of=456 so the total saving is (with the 4096 of mStackArena) 4144 bytes. After shuffling fields around, and narrowing the size of some, I get: sizeof=408 moz_malloc_size_of=408 I'll file a separate bug for that.
Comment on attachment 620762 [details] [diff] [review] fix, v2 Review of attachment 620762 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/tables/BasicTableLayoutStrategy.cpp @@ +264,5 @@ > { > nsTableFrame *tableFrame = mTableFrame; > nsTableCellMap *cellMap = tableFrame->GetCellMap(); > > + mozilla::AutoStackArena mArena; Just call this "arena" since it's not a member.
Attachment #620762 -
Flags: review?(roc) → review+
Assignee | ||
Comment 13•12 years ago
|
||
> Just call this "arena" since it's not a member. Thanks, fixed. https://hg.mozilla.org/integration/mozilla-inbound/rev/97d04250e23c
Target Milestone: --- → mozilla15
Comment 14•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/97d04250e23c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 15•12 years ago
|
||
How many nsPresShells do we have live at a time?
Comment 16•12 years ago
|
||
One per document being rendered.
Assignee | ||
Comment 17•12 years ago
|
||
It seems we keep a few in the bfcache as well. Here's the results I get: start up with 1 tab (about:home) 3 shells load in that tab -- mozilla.com, about:home, ... +1 for each page up to 6 create a new tab (about:home): +1 (total 7) loading in tab 2 -- mozilla.com, about:home, ... +1 for each page up to 10
Comment 18•12 years ago
|
||
Oh, right. One per document being shown or in bfcache. ;)
Assignee | ||
Comment 19•12 years ago
|
||
Yeah, and not to forget, each window has a XUL document. I was quite impressed to see that "Minimize memory usage" in about:memory reclaims the ones in bfcache.
You need to log in
before you can comment on or make changes to this bug.
Description
•