Closed
Bug 751355
Opened 12 years ago
Closed 12 years ago
Linux and Fennec profiling builds should be built with disable elfhack and not strip symbols
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file, 1 obsolete file)
1.64 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This will let us pull the symbols from the link cache on android when profiling and along with bug 751034 be able to profile tinderbox profiling nightly builds.
Attachment #620462 -
Flags: review?(ted.mielczarek)
Comment 1•12 years ago
|
||
Comment on attachment 620462 [details] [diff] [review] patch Review of attachment 620462 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +1960,5 @@ > MOZ_PROFILING=1, > MOZ_PROFILING= ) > > +# For profiling builds keep the symbol information > +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything unless STRIP_FLAGS is already set. @@ +7468,5 @@ > USE_ELF_HACK=, > USE_ELF_HACK=1) > > +# Disable elf hack for profiling because the built in profiler > +# doesn't read the segments properly with elf hack. Is this something worth fixing in the profiler?
Attachment #620462 -
Flags: review?(ted.mielczarek) → review-
Updated•12 years ago
|
Assignee: nobody → bgirard
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #1) > Comment on attachment 620462 [details] [diff] [review] > patch > > Review of attachment 620462 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: configure.in > @@ +1960,5 @@ > > MOZ_PROFILING=1, > > MOZ_PROFILING= ) > > > > +# For profiling builds keep the symbol information > > +if test "$MOZ_PROFILING" -a -n "$STRIP_FLAGS"; then > > Did you mean '-z "$STRIP_FLAGS"'; here? As written this won't do anything > unless STRIP_FLAGS is already set. > > @@ +7468,5 @@ > > USE_ELF_HACK=, > > USE_ELF_HACK=1) > > > > +# Disable elf hack for profiling because the built in profiler > > +# doesn't read the segments properly with elf hack. > > Is this something worth fixing in the profiler? For sure, I plan on fixing this on relatively soon. But for now I wanted to take a temporary way around it.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #620462 -
Attachment is obsolete: true
Attachment #621082 -
Flags: review?(ted.mielczarek)
Updated•12 years ago
|
Attachment #621082 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ec6652da8b9
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ec6652da8b9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•