751493 - move out the nsHTMLComboboxListAccessible logic from nsHTMLSelectListAccessible::NativeRole

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

just add nsHTMLComboboxListAccessible::NativeRole() and remove the related things from nsHTMLSelectListAccessible::NativeRole (http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHTMLSelectAccessible.cpp#89)

Comment 1

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v1)

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 621899 [details] [diff] [review]
Patch(v1)

Review of attachment 621899 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ -91,5 @@
> -  if (mParent && mParent->Role() == roles::COMBOBOX)
> -    return roles::COMBOBOX_LIST;
> -
> -  return roles::LISTBOX;
> -}

you should keep this method but it should return roles::LISTBOX

@@ +738,5 @@
> +{
> +  if (mParent && mParent->Role() == roles::COMBOBOX)
> +    return roles::COMBOBOX_LIST;
> +
> +  return roles::LISTBOX;

this one should return roles::COMBOBOX

Comment 3

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v2)

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 623598 [details] [diff] [review]
Patch(v2)

nsHTMLSelectListAccessible can't have COMBOBOX_LIST role, so remove this part

Comment 5

[Jignesh Kakadiya [:jhk]]

Attachment: Patch(v3)

Comment 6

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec2594f42e9e

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec2594f42e9e