Closed
Bug 751511
Opened 12 years ago
Closed 12 years ago
Remove -fno-common flag
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.05 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
AFAICS from the CVS history, -fno-common has been there on OSX only since the 2000, when the build was made to work on OSX. I see no reason to keep it, especially considering we don't use the flag on other platforms. It also breaks my jemalloc3 queue because I rely on -fcommon to override jemalloc overridable variables (thus avoiding modifying jemalloc upstream source code and possible future merge conflicts). I could remove -fno-common when building jemalloc only, but I don't think it hurts to just remove it completely.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #620635 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #620718 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #620635 -
Attachment is obsolete: true
Attachment #620635 -
Flags: review?(ted.mielczarek)
|
||
Updated•12 years ago
|
Attachment #620718 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5854da577bcb
Target Milestone: --- → mozilla15
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5854da577bcb
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•