751783 - Save globals between execute_script calls in the 'content' context

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

Currently, each call to execute_script or execute_async_script uses a new sandbox, so the sandbox globals are not carried over, and the only way to share state between calls is to use a property on the window object.

This contaminates the page's JS context, and makes it a little more work to write tests.  We should preserve globals between calls, so that this isn't necessary.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1 (v1): Reuse the content sandbox

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Patch looks good to me! We just need to make sure it doesn't break any of the tests

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: Part 1 (v2): Reuse the content sandbox

Added the newSandbox argument to execute* calls to preserve functionality with Selenium, and updated the tests.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 622449 [details] [diff] [review]
Part 1 (v2): Reuse the content sandbox

Looks good, and tests pass!  Let's land it and then we can update the chrome code in a separate patch.

Comment 5

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/mozilla-central/rev/b54871d38ed1

Comment 6

[Philipp von Weitershausen [:philikon]]

(In reply to Jonathan Griffin (:jgriffin) from comment #4)
> Looks good, and tests pass!  Let's land it and then we can update the chrome
> code in a separate patch.

Let's do it in a separate bug. I'm not a big fan of lingering half-landed bugs. Filed bug 755036.