751797 - crash printing due to font inflation

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I hit a crash printing in a debug build due to font inflation code.  This crash would also affect builds with font inflation enabled and affect other sorts of pagination (e.g., multicol).  (There's some font inflation code that I intentionally run in debug builds even when font inflation is disabled, so that we see the assertions.)

In any case, this patch fixes it; it's one place I missed maintaining the invariant that this function operates only on first-in-flows.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d81667d36dd

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 2

Crashed again; turns out I missed another one.  Hopefully this is really the last one, though.

Comment 3

[Ed Morley [:emorley]]

(In reply to David Baron [:dbaron] from comment #1)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/4d81667d36dd

https://hg.mozilla.org/mozilla-central/rev/4d81667d36dd

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33168c4c4703

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/33168c4c4703

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 620934 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 706193
User impact if declined: crash
Testing completed (on m-c, etc.): on mozilla-central for a bit
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: none

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 621050 [details] [diff] [review]
patch 2

[Approval Request Comment]
Regression caused by (bug #): bug 706193
User impact if declined: crash
Testing completed (on m-c, etc.): on mozilla-central for a bit
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: none

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3421c2085f49
https://hg.mozilla.org/releases/mozilla-aurora/rev/65bf57670069