Closed Bug 751924 Opened 12 years ago Closed 12 years ago

JS strict warnings in gGestureSupport code because functions don't always return a value

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 15

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
JavaScript strict warning: chrome://browser/content/browser.js, line 4658: function GS_handleEvent does not always return a value
JavaScript strict warning: chrome://browser/content/browser.js, line 4630: function GS_handleEvent does not always return a value
JavaScript strict warning: chrome://browser/content/browser.js, line 4805: anonymous function does not always return a value

Also, _doAction always returns a value, but it's never looked at.
Attachment #621074 - Flags: review?(fryn)
Comment on attachment 621074 [details] [diff] [review]
patch

Thanks for converting the inefficient forEach.
Attachment #621074 - Flags: review?(fryn) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/341e99692944
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/341e99692944
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: