Closed
Bug 752092
Opened 12 years ago
Closed 12 years ago
Support building SpiderMonkey without JS_HAS_XML_SUPPORT
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
Attachments
(1 file)
29.76 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
This is something Terrence needs for GC work, and it'll help us remove XML support eventually.
Assignee | ||
Comment 1•12 years ago
|
||
This leaves JS_HAS_XML_SUPPORT defined for now, but rearranges the #ifdefs so that it'll compile if you manually hack jsversion.h and turn it off. Terrence told me he's working on a patch for this too. I trust his patch more since he's actually going to be building with E4X support off, probably for months.
Comment 2•12 years ago
|
||
Comment on attachment 621208 [details] [diff] [review] v1 Review of attachment 621208 [details] [diff] [review]: ----------------------------------------------------------------- This all looks perfectly straightforward. I don't think we have to wait for getting the tests to work before committing this since it still defaults to off. Also, double plus bonus points if you add --disable-e4x to configure -- it should be easy as easy as copying the block for --disable-incremental and updating the variable names.
Attachment #621208 -
Flags: review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8be72d70f108
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8be72d70f108
Assignee: general → jorendorff
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•