Closed Bug 752224 Opened 12 years ago Closed 12 years ago

Switch Paris binding double/int64 wrapping away from JS_NewNumberValue once we have a better API

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Unassigned)

References

(Blocks 1 open bug)

Details

Depends on bug 752223
This should also be resolved by the patch in 752223, as the bindings were changed when JS_NewNumberValue() went away and was replaced by an always inlined non-footgunny version with the same functionality. Is this sufficient? We will still need to do something about the WebIDL [Clamp] rounding thing, as Boris suggests.
What [Clamp] thing?

What we have after bug 752223 seems pretty reasonable to me, unless it would be better to use DOUBLE_TO_JSVAL for the float/double cases.  Whether that's better sort of depends on the jit and on what sorts of values usually come out of such properties, right?

Probably worth a separate bug on that if we think it's useful.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.